-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Component services in Component class #20217
Merged
wilsonge
merged 49 commits into
joomla:4.0-dev
from
Digital-Peak:j4/extension/content/service/locator
May 6, 2018
Merged
[4.0] Component services in Component class #20217
wilsonge
merged 49 commits into
joomla:4.0-dev
from
Digital-Peak:j4/extension/content/service/locator
May 6, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce/helper # Conflicts: # libraries/src/Extension/Component.php
…ce/helper # Conflicts: # administrator/components/com_content/services/provider.php # libraries/src/Extension/Component.php # libraries/src/Extension/ComponentInterface.php # libraries/src/Extension/LegacyComponent.php # libraries/src/Extension/Service/Provider/Component.php
This was referenced May 23, 2018
This was referenced Aug 6, 2018
This was referenced Aug 16, 2018
This was referenced Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #19580.
Summary of Changes
This pr illustrates how I see the component services implemented. Through an interface the component class defines which services it provides. The base
ComponentInterface
contains now only thegetDisptacher
function as this is mandatory for every component. Like that we can introduce new services later without a BC break and do not loose any type hinting.For every service is a trait available to avoid duplicate code amongst the other components. The following code should illustrate how such a component class will look like:
Additionally the interface
BootableExtensionInterface
is added where a component class can load its internal class loader or register HTML services in a boot function:Testing Instructions
Expected result
All is working as expected.
Actual result
All is working as expected.
Documentation Changes Required
Needs a bigger update on docs.